Skip to content

build: add clang support for pgo on macOS/Linux - #66136

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:pgo-clang
Sep 26, 2026
Merged

build: add clang support for pgo on macOS/Linux#66136
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:pgo-clang

Conversation

@legendecas

@legendecas legendecas commented Sep 19, 2026

Copy link
Copy Markdown
Member

This adds clang support for pgo build on macOS and Linux.

This converts the pgo.ps1 script, to be a python script so that
it can be shared between platforms.

@legendecas
build: add clang support for pgo on macOS/Linux
4ebe4a4 
Signed-off-by: Chengzhong Wu <legendecas@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2026 •
edited by legendecas
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/build

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Sep 19, 2026
joyeecheung
joyeecheung reviewed Sep 23, 2026
View reviewed changes
Comment thread tools/pgo/README.md
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77812/

@legendecas legendecas added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 24, 2026
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 25, 2026
@nodejs-github-bot nodejs-github-bot added the lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. label Sep 25, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 71c6391 into nodejs:main Sep 26, 2026
100 checks passed
@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Landed in 71c6391

@nodejs-github-bot nodejs-github-bot removed commit-queue PRs queued for automated landing through the Commit Queue. lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. labels Sep 26, 2026
aduh95 pushed a commit that referenced this pull request Sep 27, 2026
@legendecas @aduh95
build: add clang support for pgo on macOS/Linux
d748bb7 
Signed-off-by: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #66136
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
HoonDongKang pushed a commit to HoonDongKang/node that referenced this pull request Sep 28, 2026
@legendecas @HoonDongKang
build: add clang support for pgo on macOS/Linux
98ebbe2 
Signed-off-by: Chengzhong Wu <legendecas@gmail.com>
PR-URL: nodejs#66136
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legendecas @nodejs-github-bot @joyeecheung @panva